Add fetch in progress check to empty page icon - #35
Merged
volodymyr-chekyrta merged 1 commit intoMay 31, 2023
Merged
Conversation
volodymyr-chekyrta
approved these changes
May 31, 2023
volodymyr-chekyrta
deleted the
bugfix/replace-emty-view-on-dashboard-by-progress-view
branch
May 31, 2023 14:15
shafqat-muneer
pushed a commit
to shafqat-muneer/openedx-app-ios
that referenced
this pull request
Jul 30, 2024
Fix forgot password something went wrong error
IvanStepanok
added a commit
to raccoongang/openedx-app-ios
that referenced
this pull request
Sep 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR adds a check for the fetch-in-progress flag to the empty page icon. Previously, the icon would only be displayed if the courses array was empty. However, if a fetch was in progress, the user may still see a loading indicator instead of the empty page icon. With this change, if a fetch is in progress or the courses array is empty, the empty page icon will be displayed. This provides a better user experience and ensures that the empty page icon is displayed consistently.